Skip to content

Conversation

@MosGeo
Copy link

@MosGeo MosGeo commented Jan 6, 2026

Details Resolves #459 by removing setuptools as a core requirement in lightning-utilities. As far as I can see, the removal should not affect anything.
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

Note: for local tests of CLI, I had to manually point it to the virtual environment. Right now, the test attempts to access the global Python on the OS.

What does this PR do?

Resolves #459.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--461.org.readthedocs.build/en/461/

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@3a46c4c). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             main   #461   +/-   ##
=====================================
  Coverage        ?    63%           
=====================================
  Files           ?     17           
  Lines           ?    740           
  Branches        ?      0           
=====================================
  Hits            ?    468           
  Misses          ?    272           
  Partials        ?      0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setuptools as part of core requirements

3 participants